search

tangrams / refill-style

From Toner to Tangram
https://tangrams.github.io/refill-style
MIT License
34 stars 12 forks source link

ux_language_text_source_continent breaks shaped text for continents #69

Open tallytalwar opened 7 years ago

tallytalwar commented 7 years ago

Splitting of continent names breaks shaping. Refer the screenshots below for an example with hindi.

I think the issue is with name.split('').join(' ');, but I am not sure what solution can be applied here to make sure split happens at the apt location. The solution should aptly handle different text rendering strategies on JS and ES.

screen shot 2017-08-30 at 4 36 21 pm screen shot 2017-08-30 at 4 36 01 pm screen shot 2017-08-30 at 12 57 56 pm screen shot 2017-08-30 at 12 57 24 pm screen shot 2017-08-30 at 12 55 02 pm

cc. @nvkelso

nvkelso commented 7 years ago

We probably need to add support for letter spacing to the text engine.

On Aug 30, 2017, at 19:32, Varun notifications@github.com wrote:

Splitting of continent names breaks shaping. Refer the screenshots below for an example with hindi.

I think the issue is with name.split('').join(' ');, but I am not sure what solution can be applied here to make sure split happens at the apt location. The solution should aptly handle different text rendering strategies on JS and ES.

cc. @nvkelso

― You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.