[WIP] Performance improvements

tangrams / refill-style

From Toner to Tangram

https://tangrams.github.io/refill-style

MIT License

34 stars 12 forks source link

[WIP] Performance improvements #93

Open nvkelso opened 5 years ago

nvkelso commented 5 years ago

[x] Set offset to array
[x] Always use same units in an array (like in offset)
[x] Add sizes on textures to for Tangram ES
[x] Simplify shield handling
[x] move JS functions to last filter eval
[x] Generally simplify layer filter setup
[x] Trust the server more for things like water areas
[x] Cleanup water waves shader (assigned to @tallytalwar)
[x] Cleanup other shader changes, including dots, etc (assigned to @tallytalwar)
[x] Other shader cleanups
[x] Better language filtering for country, region labnels
[x] Hillshade shader changes (not clear if necessary) - (@tallytalwar: no grave perf issues here)
[x] Dashes as style versus draw params for ferry, rail, steps (for Tangram ES) - (assigned to @tallytalwar, to make it work for ES) (f4192ac, 08aea82)
[x] lossless compress all textures (ef02ef3)
[x] Upgrade to Tangram JS v0.18
[ ] Eye ball visual regressions

nvkelso commented 5 years ago

@tallytalwar Can you take a look at the shader errors here, please? Looks like it fails completely in Tangram JS v0.18 while partially fails in v0.16, from waves shader. There's also another one related to a shader color.

Tangram v0.16.1 [error]: Style: error compiling program for style 'dots-rev' (program key 'program') 
Tangram v0.16.1 [error]: Style: error compiling program for style 'dots-rev-grid' (program key 'program') 
Tangram v0.16.1 [error]: Style: error compiling program for style 'horizontal-bars' (program key 'program') 
Tangram v0.16.1 [error]: Style: error compiling program for style 'waves' (program key 'program')

tallytalwar commented 5 years ago

@nvkelso Sure, assigned myself to a few things in the description above.

tallytalwar commented 5 years ago

Savings from lossless compressions.

tallytalwar commented 5 years ago

@nvkelso over to you now.

nvkelso commented 5 years ago

For the waves shader, I like how the position is constant now, but can we do something similar to the landuse dots in Bubble Wrap dots – where the waves size is more "constant" looking for the 2 major waves, but the new wave that's introduced grows from a pixel to a full line width wave during the zoom?

=====
=====

=====
-----
=====

=====
=====
=====

nvkelso commented 5 years ago

From @meetar, about the wave pattern:

My 2¢: I'd suggest eventually switching to a texture, and crossfading between zooms, as in the current map. I have an example using Tangram here: http://tangrams.github.io/texture-demos/?url=scenes/texture-tiles.yaml

tallytalwar commented 5 years ago

Cross fade for texture is good, but I think we can have a pure mathematical implementation for desired wave transitions.