search

tangrams / tangram-es

2D and 3D map renderer using OpenGL ES
MIT License
823 stars 239 forks source link

Android 12 system font support #2306

Closed matteblair closed 2 years ago

matteblair commented 2 years ago

Resolves https://github.com/tangrams/tangram-es/issues/2303

Despite the availability of a new SystemFonts API in Android API level 29 and above, it turned out to be easier and faster to modify the FontConfig XML parsing code to handle the format of fonts.xml in versions before and after Android 12. As mentioned in the issue though, we will still need to add support for font variation axes to render the bold or italic versions of many system fonts.

westnordost commented 2 years ago

With more and more people upgrading to Android 12, this is becoming more and more of a problem. My app has mostly users from the EU and US and I see now that 17% of users use Android 12, as opposed to 10% when the issue was first reported. As this is already fixed, are you planning to do a release soon?

Or were you waiting on feedback from the issue reporter or me whether the fix works correctly? I do have an Android 12 phone now, but I have no tangram-es development environment set up.

rwrx commented 2 years ago

@westnordost I can confirm that it is fixed with this pull request.

matteblair commented 2 years ago

I actually hadn't realized that this change had not been included in a release yet. I'll prioritize making a new release so that this becomes available to downstream users. Sorry to make you wait so long for this fix!

KS-Balaji commented 2 years ago

I have pulled this source. Now the fonts rendering was slow in some android 12 devices. @matteblair any ideas?