tangrams / tangram-es

2D and 3D map renderer using OpenGL ES
MIT License
823 stars 239 forks source link

runTextureTasks possible bug that leads to memory stomp crash #2324

Closed mkandulavm closed 1 year ago

mkandulavm commented 2 years ago

In scene.cpp, runTextureTasks() is called twice.

While harmless to naked eye, commenting the first one at line 153 is possibly required to avoid a potential crash (which rarely occurs for me and believe this is the cause for it) due to memory stomping. I am thinking, this can happen when a texture task got completed during first call, is being called again in the second call, leading to the memory stomping which is very hard to detect.

Please do correct me if I am wrong in any analysis of the above.