search

tangrams / tangram-frame

A nice frame for displaying a Tangram map.
MIT License
9 stars 3 forks source link

Remove extraneous attribution #37

Closed louh closed 7 years ago

louh commented 7 years ago

Currently:

Leaflet | Tangram | © OSM contributors | Mapzen, Geocoding by Mapzen

We can remove Geocoding by Mapzen, which is added by the geocoder component inside of mapzen-ui. (Although this is slightly easier said than done.)

nvkelso commented 7 years ago

I'm seeing this credit in more and more blog posts which include Tangram Frame maps.

Since this issue was filed we also changed Mapzen rights recommendation to:

© <a href="https://www.mapzen.com/rights">Mapzen</a>, <a href="https://openstreetmap.org/copyright">OpenStreetMap</a> , and <a href="https://www.mapzen.com/rights/#services-and-data-sources">others</a>.

I think Leaflet | is always added by Leaflet, so if we want to credit Tangram (which seams reasonable since it's a promo for Tangram the product) than we'd do:

<a href="https://mapzen.com/tangram">Tangram</a> | © <a href="https://www.mapzen.com/rights">Mapzen</a>, <a href="https://openstreetmap.org/copyright">OpenStreetMap</a>, and <a href="https://www.mapzen.com/rights/#services-and-data-sources">others</a>.

This is configured on:

(And not specifically call out Geocoding, as that's covered in the general Mapzen credit, but would require other related changes at Lou notes above.)

louh commented 7 years ago

We recently swapped out the code under the hood of tangram-frame to use mapzen.js, which fixed the original extraneous attribution problem. Although mapzen.js automatically adds the recommended Mapzen rights, we were overwriting it here in tangram-frame. It may make sense to do the following instead:

This would result in an attribution that looks like this (imagine the links):

© Mapzen, OpenStreetMap, and others | Leaflet, Tangram

nvkelso commented 7 years ago

Works for me :)

On Thu, Mar 16, 2017 at 12:03 PM, Lou Huang notifications@github.com wrote:

We recently swapped out the code under the hood of tangram-frame to use mapzen.js, which fixed the original extraneous attribution problem. Although mapzen.js automatically adds the recommended Mapzen rights, we were overwriting it here in tangram-frame. It may make sense to do the following instead:

  • Allow mapzen.js to add the recommended Mapzen rights by default. If in the future our recommendation changes, upgrading mapzen.js will bring those in.
  • use the map's attribution control method addAttribution() to append the credit to Tangram.

This would result in an attribution that looks like this (imagine the links):

© Mapzen, OpenStreetMap, and others | Leaflet, Tangram

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tangrams/tangram-frame/issues/37#issuecomment-287159476, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0EO8OyOpTdT5K4aWgjiw_d7rmazBNhks5rmYd3gaJpZM4LRNvk .