search

tangrams / tangram

WebGL map rendering engine for creative cartography
https://tangram.city
MIT License
2.21k stars 290 forks source link

incorrect point widths #492

Closed meetar closed 7 years ago

meetar commented 7 years ago

TO REPRODUCE THE ISSUE, FOLLOW THESE STEPS:

Make a point of size: 100px :

https://mapzen.com/tangram/play/?scene=https%3A%2F%2Fmapzen.com%2Fapi%2Fscenes%2F5%2F187%2Fresources%2Fscene.yaml#1.2/33.5/-135.9

RESULT:

Resulting points are about 176 pixels wide on a retina screen.

Seen on Mac FF/Safari/Chrome.

bcamper commented 7 years ago

Oh haven't looked yet but this may be an issue with running out of precision in the vertex attribute packing for the width.

hanbyul-here commented 7 years ago

I found this incorrect point width problem while building [this] (https://hanbyul-here.github.io/seoul-metro-turnstile-data/map/#lat=37.5601&lng=126.9794&z=14) the point on the map should match to the legend's circle radius (They are using same function to get its size), but it is not matching.

Also, (this can be documentation issue) the size for the point means radius or diameter ?

bcamper commented 7 years ago

Fixed by #472

bcamper commented 7 years ago

Released in v0.12.0