tangrams / tangram

WebGL map rendering engine for creative cartography
https://tangram.city
MIT License
2.22k stars 290 forks source link

Deformed and irregular dots on vector line. #664

Closed sk1me closed 6 years ago

sk1me commented 6 years ago

TANGRAM VERSION:

15.2

ENVIRONMENT:

Windows 10, Chrome

TO REPRODUCE THE ISSUE, FOLLOW THESE STEPS:

Use shader for tangram: http://tangrams.github.io/blocks/#lines-dots

RESULT:

Dots on vector line are irregular, deformed and sharp. image image

There is also problem with using dashed lines - irregular chunks of lines.

EXPECTED RESULT:

Beautiful, smooth and placed within regular space dots.

nvkelso commented 6 years ago

@sk1me That's an old example with raw shader code.

Try the newer implementation as documented here:

meetar commented 6 years ago

Note that the dash parameter is for dashes only – there's no equivalent "dots" line style. For dots you'll still need a custom shader. For smooth dots you'll need a shader with antialiasing built in, but spacing will still be an issue, as UV coordinates are not consistent between features or across tiles.

meetar commented 6 years ago

@sk1me Just saw your reaction emoji 😅 If you let me know which parts of this are confusing I can try to shed some more light on the issue for you… Regardless, as this seems to be an issue with this particular shader and not the library, I'll close it.

If you have any more implementation questions feel free to throw a message into the gitter channel: https://gitter.im/tangrams/tangram-chat