search

tangrams / tangram

WebGL map rendering engine for creative cartography
https://tangram.city
MIT License
2.22k stars 290 forks source link

update geojson-vt to ^3.2.1 #744

Closed meetar closed 4 years ago

meetar commented 4 years ago

Updating geojson-vt for performance and edge-case handling improvements. Passed all Differ tests with only very minor changes to text – if anything it's made text sharper?

image

bcamper commented 4 years ago

Thanks @meetar! As a practice, we keep dependencies pegged to exact versions (https://github.com/tangrams/tangram/pull/744/commits/ab08178ea724fd061af8f1aeffa0113b9d46b39e), to avoid bugs that slip through in minor/patch upgrades (they aren't supposed to, but we've been bitten by it before, so better to explicitly test each version before upgrading).

bcamper commented 4 years ago

Re: text rendering, those don't go through geojson-vt at all (those quads are always generated internally), it's some kind of non-deterministic issue, I think with the text "pixel snapping" feature, that broke for Differ tests at some point, and I have never spent enough time to track it down... but it would be nice to fix, since it's misleading. OTOH, since label placement itself is now non-deterministic, as of the addition of main thread / cross-data-source collisions, these tests will continue to be as well, even if the rendering issue is fixed :/