search

tangrams / tangram

WebGL map rendering engine for creative cartography
https://tangram.city
MIT License
2.22k stars 290 forks source link

bump earcut version #755

Closed bdon closed 4 years ago

bdon commented 4 years ago

I was seeing some sliver polygons being created - was resolved by bumping earcut to the latest. also regenerated the package-lock.json

bcamper commented 4 years ago

Thank you! I will take a look and bundle as a release with the variable font weight support (to avoid multiple XHRs for a single font file) that I've been sitting on for far too long 😬

bdon commented 4 years ago

~FYI, I'm noticing some new, different triangulation artifacts on this new version - will need to confirm if they were introduced by this change~ ignore, unrelated

meetar commented 4 years ago

This sounds like a job for

The Differ

On Jun 5, 2020, at 6:27 PM, Brandon Liu notifications@github.com wrote:

 FYI, I'm noticing some new, different triangulation artifacts on this new version - will need to confirm if they were introduced by this change

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

bdon commented 4 years ago

OK, It looks like the issue I'm seeing is tangram-specific but was not introduced by this PR, so the upgrade should still be good. EDIT: can't reproduce independently, ignore

bcamper commented 4 years ago

Verified with differ (@bdon this may interest you for future use):