tangrams / walkabout-style

Preview map:
https://tangrams.github.io/walkabout-style
MIT License
32 stars 14 forks source link

Default labels should enable all road labels early #131

Closed nvkelso closed 7 years ago

nvkelso commented 7 years ago

To match the JS rig, and related to https://github.com/tangrams/tangram/pull/484#issuecomment-278506017. The older logic is from Tangram era 0.7 but articulated labels changes more recently and the about to land curved labels make these labels look good earlier now.

Here's what the JS has, the YAML for the default labels scene file should mark them true (currently false).

text_visible_highway_e = _default;
text_visible_minor_road_e = _default;
text_visible_highway_e = _default;
text_visible_trunk_primary_e2 = _default;
text_visible_trunk_primary_e = _default;
text_visible_secondary_e = _default;
text_visible_tertiary_e = _default;
text_visible_minor_road_e = _default;
text_visible_exits_e = _default;
nvkelso commented 7 years ago

Fixed in 5dbfe65010d238fde879936f310e0ff4fb3ae4ac.