search

tangrams / walkabout-style

Preview map:
https://tangrams.github.io/walkabout-style
MIT License
32 stars 14 forks source link

Remove inapplicable 'base' draw parameter #155

Closed matteblair closed 7 years ago

matteblair commented 7 years ago

'base' applies to styles, but not draw rules.

nvkelso commented 7 years ago

How does Tangram know that highlight is a line style then? Do we need to add highlight as a new style in the styles section?

nvkelso commented 7 years ago

I verified that the yellow highlights still draw using this branch, but am confused why that is. Leaving open until I get the 411 from @matteblair.

matteblair commented 7 years ago

highlight is declared as a style with base: lines in the main scene file: https://github.com/tangrams/walkabout-style/blob/gh-pages/walkabout-style.yaml#L875-L876

matteblair commented 7 years ago

Any more questions on this?

nvkelso commented 7 years ago

No questions, per say. For an include I’d rather have the styles not refer to something in the base scene file so there aren’t gotchas, so I need to think about that a bit.

On Mon, Mar 27, 2017 at 9:08 AM, Matt Blair notifications@github.com wrote:

Any more questions on this?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/tangrams/walkabout-style/pull/155#issuecomment-289501737, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0EO9ESvvJuWVVnOIdqtQq6cZ1DHGRHks5rp98UgaJpZM4Mb7z2 .

matteblair commented 7 years ago

That's a good thought.

But just to be clear, the lines removed here aren't extra, redundant specifiers of the style - they specify nothing at all. These wouldn't address the 'gotcha' that you're describing.

matteblair commented 7 years ago

Rebased against gh-pages. This still seems like a sensible clean-up.

nvkelso commented 7 years ago

Fixed in 190249aa6c109c2f7584ecc0b7c413847cb45243 instead.