tangrams / walkabout-style

Preview map:
https://tangrams.github.io/walkabout-style
MIT License
32 stars 14 forks source link

Collision of some features #161

Closed karimnaaji closed 7 years ago

karimnaaji commented 7 years ago

@nvkelso what is the layer representing those boxes in the screenshot? I couldn't find the layer in the stylesheet, but I guess they are trees. There can be a lot of those around in Paris area parks which can impact performance with our dynamic collision system on tangram-es.

If they don't need collision it would be best turned off.

screen shot 2017-03-16 at 3 43 30 pm

nvkelso commented 7 years ago

Those are kind:tree features from the POIs layer. It’s probably fine to turn collision off for them, I’ll have a look. Thanks for the tip!

On Thu, Mar 16, 2017 at 12:48 PM, Karim Naaji notifications@github.com wrote:

@nvkelso https://github.com/nvkelso what is the layer representing those boxes in the screenshot? I couldn't find the layer in the stylesheet, but I guess they are trees. There can be a lot of those around in Paris area parks which can impact performance with our dynamic collision system on tangram-es.

If they don't need collision it would be best turned off.

[image: screen shot 2017-03-16 at 3 43 30 pm] https://cloud.githubusercontent.com/assets/7061573/24015655/7ad83458-0a5f-11e7-9d4a-2907aa78d2ba.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tangrams/walkabout-style/issues/161, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0EO_-it-5Ty4G_Lwu_a3mxL6MXJVpxks5rmZH6gaJpZM4MfyxP .

nvkelso commented 7 years ago

Fixed in cf9c622253adc74ad33faae1316483aaa21d610e.

nvkelso commented 7 years ago

Actually looks better this way, too! :)

screen shot 2017-04-27 at 17 26 21