tangrams / walkabout-style

Preview map:
https://tangrams.github.io/walkabout-style
MIT License
32 stars 14 forks source link

Partially missing terrain at zoom 9 #183

Open zerebubuth opened 7 years ago

zerebubuth commented 7 years ago

Sometimes it seems like tiles can be "partially missing" terrain. I've only seen this happen at zoom 9. The colourised terrain for parks or forests seems to show, but not the "background" grey terrain. For example, around Marin, near San Francisco, USA:

image

Or around Copenhagen, Denmark:

image

I've looked at the terrain tiles (normal PNGs) which are being loaded, and nothing seemed immediately off about them. However, the effect does reappear across Ctrl-Shift-R and in an Incognito window, which suggests it might be something to do with the data, or how it's styled.

bcamper commented 7 years ago

Hmm, I haven't seen this yet myself. Can you check the console any warnings/errors when this occurs? I'm wondering if it could be a problem with GL texture binding or the texture getting prematurely freed (just speculation).

We know the normal texture loaded OK, because one of the other texture tints is rendering properly.

bcamper commented 7 years ago

Can you also let me know what browser(s) you've seen it in?

nvkelso commented 7 years ago

No console errors in either browser for me.

nvkelso commented 7 years ago

I've also only seen this happening at zoom 9. Zoom out to zoom 8 and the same place will render correctly, zoom in to 10 and it'll also render correctly.

nvkelso commented 7 years ago

Looks like the MVT format is missing land layer entirely (while other formats include land layer content). So likely an MVT encoding geometry validity problem.

bcamper commented 7 years ago

Drawing earth layer as red (no rasters/terrain):

screen shot 2017-05-22 at 4 12 29 pm

Hat tip to @meetar for tracing this to the data source change.