tangrams / walkabout-style

Preview map:
https://tangrams.github.io/walkabout-style
MIT License
32 stars 14 forks source link

[bikemap] Add bridleway type roads to "track" type brown display #188

Open nvkelso opened 7 years ago

nvkelso commented 7 years ago

A user in United Kingdom reports we can improve our bike map this way by adding bridleways to the general okay to ride bikes category. I propose adding it to the brown "tracks" section.

nvkelso commented 7 years ago

16/53.1361/-1.3461

bridleway
nvkelso commented 7 years ago
bike_tier1_off_road_filter:
         any:
             - { is_bicycle_related: true, kind_detail: [cycleway, path, pedestrian, steps, bridleway, raceway, corridor] }
+            - kind_detail: [bridleway]
             - cycleway: [sidepath, track, opposite_track, buffered_lane]
             - cycleway_left: [sidepath, track, opposite_track, buffered_lane]
             - cycleway_right: [sidepath, track, opposite_track, buffered_lane]
@@ -697,7 +742,7 @@ global:
     # brown
     bike_tier1_off_road_track_filter:
         all:
-            - { is_bicycle_related: true, kind_detail: [track, footway] }
+            - { is_bicycle_related: true, kind_detail: [track, footway, bridleway] }
cjkiller commented 7 years ago

track bridleway

Hi. I was probably the user in question, just spent yesterday playing around with styles, wish I'd seen this earlier. Code fixes it well for bikes, though if its a path and not a track it would be good to be a single brown line but not essential.

Maybe needs a new issue but with the path overlay I have a couple of issues. The first image shows a track with foot = yes but it shows the same as tracks around it that don't have a foot value. So private tracks look the same.

The second image is back to bridleways, even though foot = yes and its even is a walking_network it does not render anything.

I'll have a quick play with it but not getting to grips with yaml yet.

Craig