[Android] - Notification Id & Channel Name support

tanguyantoine / react-native-music-control

Display and manage media controls on lock screen and notification center for iOS and Android.

https://www.npmjs.com/package/react-native-music-control

MIT License

697 stars 264 forks source link

[Android] - Notification Id & Channel Name support #335

Closed hellostu closed 4 years ago

hellostu commented 4 years ago

What's this PR does?

Can now set notification id and channel id from React (before these were statically assigned).

How to test:

When calling setNowPlaying can now add the following on Android:

setNowPlaying({
   "notificationId": 10,
   "channelId": "some-channel-name"
   "artist": ...,
   ...
})

bradfloodx commented 4 years ago

Thanks @hellostu and sorry it took me a few days to get back to you.

This looks helpful. Did you find an issue or something that made you close it?

Cheers Brad

hellostu commented 4 years ago

Hey @bradleyflood. I posted the PR a bit quicker than I should have done. There were some issues with my changes. But I do want to add this functionality and will follow up with another PR shortly.