adding PropTypes and defaultProps

[tangway]

decided to look into implementing PropTypes as i got annoyed at the linting errors for prop validation from https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/prop-types.md

i had to be convinced though, it's one of those things that is not absolutely needed for the app to work so i looked up the benefits you could get from using it:

• catching unexpected bugs and logging them to the console
• part of best practices as your react project scales up and it can be harder to see where the bug comes from
• a kind of documentation as other developers (and you in the future) read through the code

and for more convincing i figured i'll check out examples of large production-grade, open-source React apps to see if they use it:

• the BBC and ASTExplorer jsx codebase that uses propTypes and defaultProps
  • https://github.com/bbc/simorgh/blob/fbb00986ccb7cc7b3f7f60b4df9aa442a7eae272/src/app/legacy/psammead/psammead-image/src/index.amp.jsx#L24
  • https://github.com/fkling/astexplorer/blob/8888701e97c2efebe6fb118484e67cfc0077d08c/website/src/components/Editor.js#L223
• sentry and excalidraw uses defaultProps
  • https://github.com/getsentry/sentry/blob/62b276f71506f202cf6cd000c46efd89ab847016/static/app/components/smartSearchBar/actionButton.tsx#L24
  • https://github.com/excalidraw/excalidraw/blob/b7babe554b16201f55d2636f365e9161805c47ce/packages/excalidraw/components/ToolButton.tsx#L188

[tangway]

after reading this i decided on not using defaultProps and went back to using default parameters for react component function: https://sophiabits.com/blog/stop-using-defaultprops

• it was introduced a long time ago to get around the deficiencies of Javascript
• it has bad performance
• doesnt work well with modern web dev tooling