Markers overwritten and lost when given same description

[GoogleCodeExporter]

What steps will reproduce the problem?
 1. In map view right click and enter marker. Do this more than once.
 2. Go to Edit Markers in the GMapCatcher Tools box
 3. Rename the description of the new markers with the same name
    e.g. "DE - campsite"
 4. Press the save butten to save changes
 5. Close the GMapCatcher Tools box

What is the expected output? What do you see instead?

- As was last visible in the GMapCatcher Tools box it is expected that a number 
of markers would now exist with the same description. Instead all but one 
markers are lost.

What version of the product are you using? On what operating system?

- 0.7.7.2 on eeebuntu

Please provide any additional information below.

- At least a warning should be given to prevent one from accidentally losing 
work as I did. 

- GMapCatcher together with OpenCycleMaps was recently a great help in 
navigating around Germany on a cycling holiday. :)

Original issue reported on code.google.com by cjre...@gmail.com on 22 Sep 2012 at 5:21

[GoogleCodeExporter]

Workaround :
Name markers differently. 

Original comment by heldersepu on 22 Sep 2012 at 6:53

• Changed state: Accepted

[GoogleCodeExporter]

but if we need to add two times the same name, how can we display two locations.
thanks in advance

Original comment by olivierc...@gmail.com on 29 Sep 2012 at 5:26

[GoogleCodeExporter]

Markers can not have the same name, name them Marker1, Marker2, ...

Original comment by heldersepu on 30 Sep 2012 at 12:36

[GoogleCodeExporter]

I just added logic to prevent duplicate names in the markers, see r1388

Original comment by heldersepu on 30 Sep 2012 at 2:50

• Changed state: Started
• Added labels: Milestone-Release0.8

[GoogleCodeExporter]

Another thing that would be nice if you could addressed is that in my 
development copy from 29 Sept there is a new limit of just 100 markers added, 
after which they are lost.

The following line has been changed in widTreeView:
locations = fileUtils.read_file(strInfo, strFilePath, 100)

It would be nice if this number could be expanded automatically. Over time I 
expect to be accumulating 1000's of markers and at some point it would be nice 
to be able to group them in categories.

Original comment by cjre...@gmail.com on 1 Oct 2012 at 7:17

[GoogleCodeExporter]

Also, contradictory to the header of the markers file, comments added to the 
file are not saved. This is the same for the current 0.7.7.2 version so I can 
create a new case for this if you like.

Original comment by cjre...@gmail.com on 1 Oct 2012 at 7:40

[GoogleCodeExporter]

OK, here is how it works:
The 100 is a limit to the amount of lines that will be read from the marker 
file,  this limit only applies when the items are displayed in the widget, all 
the markers will be displayed in the map correctly, and it was added to prevent 
slow downs caused by large files.
I will add this 100 limit to the config file

If you seen the comment in the markers file is because you open it with a text 
editor, that is a much better choice, but when new markers are added or you 
edit the markers any custom comments will be deleted. 

Original comment by heldersepu on 1 Oct 2012 at 1:34

[GoogleCodeExporter]

I been doing some tests and the limit causes markers to be lost, I just removed 
that limit see r1395 

Original comment by heldersepu on 1 Oct 2012 at 1:53

[GoogleCodeExporter]

Thanks for that. Also a comment in the marker file indicating that comments 
will be deleted would be helpful. 

Another thing I forgot to mention is that marker names/descriptions that 
contain forbidden characters are lost. For example, "Café Rouge" would be 
deleted from the markers when saved because the 'e' has an accent. Perhaps a 
method could be created to remove or replace just the forbidden characters 
because it is easy to insert such a character by mistake when copy and pasting.

Original comment by cjre...@gmail.com on 1 Oct 2012 at 2:17

[GoogleCodeExporter]

Make sure that the file is saved in UTF-8, if you edit it with other editors.

Original comment by kipenros...@gmail.com on 8 Oct 2012 at 3:06

[GoogleCodeExporter]

Files saved in UTF-8 in r1450.
Also allow markers with same name by adding a "random" string to the end.

Original comment by kipenros...@gmail.com on 8 Oct 2012 at 3:15

[GoogleCodeExporter]

Original comment by kipenros...@gmail.com on 8 Oct 2012 at 4:43

• Changed state: Fixed

[GoogleCodeExporter]

Released in 0.8

Original comment by heldersepu on 16 Oct 2012 at 6:06

• Changed state: Done