search

tanhevg / GpABC.jl

MIT License
54 stars 15 forks source link

Fixing bug in PosteriorSampledEmulatedParticleSelection #53

Closed jonathanishhorowicz closed 4 years ago

jonathanishhorowicz commented 4 years ago

Fixed bug in PosteriorSampledEmulatedParticleSelection - the inverse of the field use_diagonal_covariance should be passed to gp_regression_sample as the full_cov_matrix argument.

Also added tests on the AbstractEmulatedParticleSelection for both ABC Rejection and ABC-SMC

codecov-io commented 4 years ago

Codecov Report

Merging #53 into master will increase coverage by 0.46%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   73.77%   74.23%   +0.46%     
==========================================
  Files          17       17              
  Lines         915      916       +1     
==========================================
+ Hits          675      680       +5     
+ Misses        240      236       -4
Impacted Files Coverage Δ
src/gp/gp.jl 85.56% <ø> (ø) :arrow_up:
src/util/emulation_helpers.jl 89.55% <100%> (+4.47%) :arrow_up:
src/abc/io.jl 82.14% <0%> (+4.36%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ece7cf...d367a91. Read the comment docs.

tanhevg commented 4 years ago

superceded by #54