tanhevg / GpABC.jl

MIT License
54 stars 15 forks source link

Adding KLD to abc example #59

Closed jonathanishhorowicz closed 4 years ago

jonathanishhorowicz commented 4 years ago
codecov-io commented 4 years ago

Codecov Report

Merging #59 into master will decrease coverage by 0.28%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   75.21%   74.92%   -0.29%     
==========================================
  Files          18       18              
  Lines        1053     1057       +4     
==========================================
  Hits          792      792              
- Misses        261      265       +4
Impacted Files Coverage Δ
src/abc/plot_recipe.jl 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 42e4e42...26b073f. Read the comment docs.

tanhevg commented 4 years ago

See screenshot - the dotted line that indicates the true value does not touch the y axis any more (highlighted by the ellipse). This does not look right.

Maybe revert the changes to that recipe, just change the recipe for individual results.

Screenshot 2019-12-06 at 13 28 24