tanhevg / GpABC.jl

MIT License
54 stars 15 forks source link

removed compat requirements #70

Closed SamuelBrand1 closed 2 years ago

SamuelBrand1 commented 2 years ago

Simply commented out the [compat] requirements for this package. This has not lead to breaking issues with the code wrt using a model defined by Flux layers as an emulator, but I haven't extensively tested.

tanhevg commented 2 years ago

Dear Samuel,

Thank you for your interest in GpABC. It is encouraging to hear that someone still finds the package useful, after it not being developed for a while, and similar functionality available in other packages, most notably the DifferentialEquations ecosystem.

Re the [compat] section - unfortunately, having it non-empty for all dependencies is a requirement for being listed in the package registry - see https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/. We would like to stay on the registry so that users don't need to specify the github url, and can just reference the package by its name. So, as much as I am frustrated with it myself, we can't just go with empty compat.

If you could go through all the dependencies and update their versions, I will gladly re-review and accept your PR. Typically, just the non-zero major version should do, where available. The package must be re-tested with new dependencies. Unfortunately I don't have time to do this myself.

Alternatively, please feel free to play around with empty compat on your own branch.

Kind regards, Evgeny

tanhevg commented 2 years ago

compat section updated on master to the latest dependency versions and version v0.1.1 released