search

tanhevg / GpABC.jl

MIT License
54 stars 15 forks source link

Made Generic DistanceInput type to allow for non-1d summary statistics #76

Closed OmegaLambda1998 closed 3 months ago

OmegaLambda1998 commented 1 year ago

At the moment, DistanceSimulationInput requires reference_summary_statistic to be a 1 dimensional array of Float64, however the are some cases where that may not be the case. As such, I created a DistanceInput abstract type which is now the parent of DistanceSimulationInput. This allows users to create their own DistanceSimulationInput equivalent with a different type signature for reference_summary_statistic

OmegaLambda1998 commented 1 year ago

Note that this allows users to get around #63 (albeit with a good chunk of effort on their part)

tanhevg commented 1 year ago

Thanks for the PR. It would be good to have some tests that demonstrate how the new functionality works (addressing #63 ) and to make sure that subsequent changes do not break it. Also some examples and some docs.