search

taniarascia / new-moon-atom-syntax

New Moon Syntax Theme for Atom
https://taniarascia.github.io/new-moon
MIT License
25 stars 5 forks source link

SCSS Atom/Brackets parity #6

Closed lowercasedots closed 8 years ago

lowercasedots commented 8 years ago

These are centered mostly on SCSS, as that's what we use at work. It's been incredibly slow today, so I've been more nitpicky with my port - at some point I'll try to go through the other languages and get them synced up as well, but that depends on my free time.. As an example, jQuery is quite a bit different than the Brackets version. Not bad, mind you. Just.. different.

Anyway, the only scss element not matched is one type of variable which Atom doesn't have a selector for. If the value of a variable is an integer or a hex value it will match, but not when the value is a string. For now I've left string values the same pink color as the hex value, rather than the white which Brackets uses -- and I doubt anyone would notice the difference unless they have them both open side by side like I'm doing.

Also: -Fixed another super nitpicky issue with the indent guide / leading whitespace where selections would cause the indent guide to no longer match. I just copied the code you used for the whitespace selector and made the two identical.

-There was a broken link when I copied over the readme from the Brackets repo, because apparently I was on autopilot and added an 'atom-syntax' to the end of the link. (Sorry.)

Relatedly, I noticed the preview images are broken on the Atom theme page. Which also must have been my doing. Everything was copied direct from the Brackets repo so that (in theory) the newer image previews would show.. but I don't know what the hell I did, because it clearly didn't work, lol. So all the image URLs have been restored to how you had them on Nov 28th.

So that said, the next pull req proably won't be for a bit, and I'll try not to write half a novel for ten lines of minor code changes the next time I do one.

taniarascia commented 8 years ago

Thanks! Didn't even check the GitHub screenshots. I do remember having an issue with them not loading the first time around when I ported the README to Atom.

A drastic change is coming to Brackets - red variables. It actually makes the SCSS quite pleasant to look at. PHP looks a bit different, not quite as cool, but much easier to instantly differentiate between HTML blocks and PHP blocks, since tags and variables won't be the same color anymore. Anyway, once I make that update, I'll work on a more extensive nitpicky sync. Then maybe I'll start using Atom...

lowercasedots commented 8 years ago

Sounds good!

And this is sort of leaning towards general chatting, however: I find myself using Atom at around an 80/20 split these days. When I got hired by [my employer which is very similar in size and scope to godaddy], the department was just phasing out Dreamweaver CS3 in favor of Brackets. Unfortunately, where they're a large corporation, we all get near identical (underpowered) windows 7 PCs, without the admin privs to install much. I found myself liking Atom more, so to use it I have to run it (and node.js to compile scss) from a zipped portable version extracted to a network drive.

I find Atom has greater momentum right now, both in terms of people switching over and in terms of development speed. It does seem that Brackets is faster/more responsive, however a lot of that may be due to not being able to set up Atom in the most optimal way at work. (To compile scss I have to use node.js to monitor a specific directory, and if I switch to another site I have to manually reconfigure which directory to watch and which to output css to.)

Anyway, I can go into more work-specific detail privately, as public pull req comments aren't really the place, but long story short I wouldn't be surprised to see Atom continuing to gain a lot more traction.

taniarascia commented 8 years ago

You're right, Atom is significantly more popular, and has more packages going in and more of a community around it. For me the speed really is the issue - I don't think it's your setup, because it's significantly slower than Brackets or Sublime on any computer I use. I'll have to give it another chance.

taniarascia commented 8 years ago

It should be significantly better and more similar, for jQuery and SCSS as well. It was a quick fix, but when I have more time I'll try to make it even better.

lowercasedots commented 8 years ago

Awesome - I got the update when I got into work this morning (along with Atom's 1.9 beta) and used it for my current project/WIP (which is this awful thing). It felt like most of the day was dealing with a ridiculous amount of if/else statements, but the new variables definitely made them stand out / not get lost in the shuffle.

I didn't have time to compare the two theme versions side by side, but either way it looks perfectly fine even if it turns out that it's not identical to Brackets. ...which probably sounds like an odd thing for me to say given that my pull reqs were the nitpickiest shit ever, lol.