taniathng / pe

0 stars 0 forks source link

Repetition of fields for success message #4

Open taniathng opened 4 days ago

taniathng commented 4 days ago

There is a repetition of fields in success message. "Project Assignment Id: 2 Project Id: 3 Employee Id: 0 assigned to employee Assignment Id: 2 Project Id: 3 Employee Id: 0"

Also not too sure what "Employee Id: 0 assigned to employee Assignment Id:" means. Employee id 0 assigned to employee?

Steps to reproduce: command : 'assign aid/2 pid/3 id/0'

Consider a clearer more concise success message after successful assignment that does not repeat fields as this may confuse the user. Also consider the organization as having each field on separate lines is a bit confusing.

nus-se-script commented 1 day ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thanks for pointing this out!

Thanks for pointing this out. We have noted the formatting of long command messages under "Planned Enhancements" in our Developer Guide (see https://ay2425s1-cs2103t-t15-4.github.io/tp/DeveloperGuide.html#planned-enhancements) but we acknowledge that the issue described here is different from that of redundant repeated sections that you have pointed out.

image.png

Furthermore, we think that this does not affect usage of our app, as the contents still contain correct information. Also, the new assignment can still be reflected in the Assignment panel. Thus, we think this does not cause much inconvenience to the user, and we agree that the severity should be "VeryLow".

Thank you for raising this issue!

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Assign command: Success message appears to have accidental repetition

Details

Upon executing assign the success message produced is as follows: Project Assignment Id: 1 Project Id: 4 Employee Id: 3 assigned to employee Assignment Id: 1 Project Id: 4 Employee Id: 3

As can be seen, there are some repeated redundant sections.

Suggested improvement

Truncate message to remove redundant section.


[original: nus-cs2103-AY2425S1/pe-interim#2422] [original labels: type.FeatureFlaw severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for pointing this out. We have noted the formatting of long command messages under "Planned Enhancements" in our Developer Guide (see https://ay2425s1-cs2103t-t15-4.github.io/tp/DeveloperGuide.html#planned-enhancements) but we acknowledge that the issue described here is different from that of redundant repeated sections that you have pointed out.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]