search

tanishq-dubey / cowtab

A simple, fast, new tab page, with a retro feel and good advice.
MIT License
40 stars 8 forks source link

Changing background color does not work as expected #9

Closed abendebury closed 6 years ago

abendebury commented 7 years ago

If you change the background color via the settings, only a box of color near the cow gets the new color:

http://imgur.com/38sqBDK

abendebury commented 7 years ago

The issue is that the background color is specified on the html element by default:

https://github.com/tanishq-dubey/cowtab/blob/master/newtab/newtab.css#L10

But it's updated on the body element:

https://github.com/tanishq-dubey/cowtab/blob/master/newtab/newtab.js#L70

tanishq-dubey commented 6 years ago

I don't think this occurs any more, so I am closing the issue. If it still occurs, feel free to reopen.