tanishqmanuja / apkmirror-downloader

📥 Download apps from APKMirror with ease.
https://www.npmjs.com/package/apkmirror-downloader
MIT License
34 stars 8 forks source link

Filter by minimum api version #16

Closed TheUnityGuy closed 3 months ago

TheUnityGuy commented 3 months ago

I think it would be a neat feature while looking for a package for slightly older devices :)

tanishqmanuja commented 3 months ago

Nice idea 💯

tanishqmanuja commented 3 months ago

Although I have added a filter for minAndroidVersion, but still the process would have to be manual because not many apk variants have multiple supported android versions nowadays. For example YT Music only has 8.0+ for all variants.

TheUnityGuy commented 3 months ago

A solution for this might be converting that 8.0+ tag to the actual API version and comparing that number to version selected by user. At least I think so 😅. Thank you for such rapid response btw.

tanishqmanuja commented 3 months ago

Do you mean mapping the android version to the sdk version ? Like Android 15 -> API 35 etc etc. For now i guess the simple logic is best for making the scrapping easier.

TheUnityGuy commented 3 months ago

Yeah something exactly like that. Simpler logic surely is better especially for scraping, but maybe as the project is entirely in typescript you can add interfaces to make sure the data is scraped correctly and then apply the filters. Just a suggestion to make the project easier to maintain for future features 😉.

tanishqmanuja commented 3 months ago

Sure, will definitely look into this.