search

tanishqmanuja / apkmirror-downloader

📥 Download apps from APKMirror with ease.
https://www.npmjs.com/package/apkmirror-downloader
MIT License
35 stars 8 forks source link

Naming Issue #21

Closed ddubnyk closed 2 weeks ago

ddubnyk commented 3 weeks ago

I've found another issue when downloading certain apps. This one is how the download gets named.

Steam is an example of one of these.

Here is my json file.

{ "options": { "outDir": "/home/username/path/repo", "type": "apk", "overwrite": false }, "apps": [ { "org": "ookla", "repo": "speedtest", "arch": "arm64-v8a" }, { "org": "valve-corporation", "repo": "steam" } ] }

If I download this manually, the file is named: com.valvesoftware.android.steam.community_3.9.3-9305784_minAPI23(arm64-v8a,armeabi-v7a,x86,x86_64)(nodpi)_apkmirror.com.apk

However with the script it downloads as: com.valvesoftware.android.steam.community_3.9.3-9305784_minAPI23(arm64-v8a%2Carmeabi-v7a%2Cx86%2Cx86_64)(nodpi)_apkmirror.com.apk

This seems to cause issues with Fdroid repos in particular in my case. Leaving it as the original name, Fdroid has no problem with the APK, however with the way it gets renamed via the script it won't allow clients to download it. It seems as if the "," is getting replaced with "%2C".

tanishqmanuja commented 2 weeks ago

Thanks for the issue 💯

Should be fixed with (e927493fafcba668850d234e95fb6ffa70647edc) in release v2.0.8 .

Test Output:

❯ bun src/cli.ts download valve-corporation steam

*** APKMD (APKMirror Downloader) v2.0.7 ***

Downloading Steam 3.9.3...
Downloaded to ./com.valvesoftware.android.steam.community_3.9.3-9305784_minAPI23(arm64-v8a%2Carmeabi-v7a%2Cx86%2Cx86_64)(nodpi)_apkmirror.com.apk
❯ bun src/cli.ts download valve-corporation steam

*** APKMD (APKMirror Downloader) v2.0.8 ***

Downloading Steam 3.9.3...
Downloaded to ./com.valvesoftware.android.steam.community_3.9.3-9305784_minAPI23(arm64-v8a,armeabi-v7a,x86,x86_64)(nodpi)_apkmirror.com.apk