Run background workers on a tokio runtime - Githubissues

tanium / octobot

github bot with slack and jira integration

MIT License

25 stars 16 forks source link

Run background workers on a tokio runtime #207

Closed matthauck closed 6 years ago

matthauck commented 6 years ago

Need to be on an event loop thread to be able to spawn new events onto the event loop. In particular, HTTPClient requests need to be initiated from event-loop threads.

So, run all the workers on a tokio runtime, not threadpools!

Also:

Reap the benefits of moving closer to more async by using futures for more than just http layer responses.
Use a separate runtime to be able to separate out http server from background jobs.
Better testability since it avoids the complication of threads to process the mpsc channel

matthauck commented 6 years ago

Sorry again for the mountain of changes that may feel like no net new change in functionality. Just trying to keep up to date with the libraries and the tokio event loop in particular as they march forward towards a stable api.