search

tanium / octobot

github bot with slack and jira integration
MIT License
25 stars 16 forks source link

Support restricting Jira comment visibility by role. #245

Closed thomsavage closed 4 years ago

thomsavage commented 4 years ago

Jira supports restricting comment visibility to specific user roles. Octobot admins can use this property set restrict comment visibility of PR updates to only interested roles (e.g. "Developers").

I'm new to Rust and would be grateful for any assistance getting this over the finish line.

jmealins commented 4 years ago

thom just to understand, why do we want to restrict visibility? to reduce potential leakage of security focused comments? or

thomsavage commented 4 years ago

I think this feature is generally applicable to octobot. My primary use case is to avoid Slack spam by suppressing the octobot Jira comments.

I want the octobot comments to be available when browsing in Jira, but I don't want them to spam my channel the same way I want regular comments from real people to. The Jira integration in Slack by default opts-out comments with any visibility restrictions set, so configuring octobot to set a visibility restriction hides the spammy comments.

thomsavage commented 4 years ago

@matthauck After a few attempts, I'm giving up on writing unit tests for the comment_issue trait implementation as out of my depth without significant time investment. Also, more sadly, I've not been able to configure my local octobot to manually verify this functionality works as intended. As you have the domain expertise to make quick work of that, can you please assist me with getting across the finish line? I'd really like to use this feature as soon as we can get it landed.