Octobot doesn't update Jira ticket with fix version when merging into a main branch named `main`

tanium / octobot

github bot with slack and jira integration

MIT License

25 stars 16 forks source link

Octobot doesn't update Jira ticket with fix version when merging into a main branch named `main` #247

Closed justfalter closed 4 years ago

justfalter commented 4 years ago

Since renaming master to main, Octobot stopped setting a fix-version when merging into the branch. Looking at the codebase, I can see that is_main_branch assumes the main branch to be named master, develop, or have the release branch prefix.

My suggestion: add a repo config option for a regular expression that is to be used for matching the main branch of a repository, and have it default to ^(main|master|develop)$.

mize-at-work commented 4 years ago

Repo config option with regex would be great! We named Console default branch default to line up with GitHub labeling.

mize-at-work commented 4 years ago

Fixed by https://github.com/tanium/octobot/pull/248?