taniwha / Extraplanetary-Launchpads

GNU General Public License v3.0
53 stars 45 forks source link

ElectricCharge input for ECHeatedSmelter is wrong #204

Open PhaserArray opened 1 year ago

PhaserArray commented 1 year ago

The ElectricalCharge input for ECHeatedSmelter is set to 5661.3 and that results in insane values in-game for parts that use this converter config, such as the Sandcastle electric smelters.

https://github.com/taniwha/Extraplanetary-Launchpads/blob/0bb3c5b0bf083e4284611682cc4f65f6b4a9d77b/GameData/ExtraplanetaryLaunchpads/Resources/ECSmelter.cfg#L40-L48

https://github.com/taniwha/Extraplanetary-Launchpads/blob/0bb3c5b0bf083e4284611682cc4f65f6b4a9d77b/GameData/ExtraplanetaryLaunchpads/Resources/ECSmelter.cfg#L61-L67

Assuming an input of 0.00044 ElectricalCharge is 0.44EC/g as shown by the ECHeatedRemelter definition, the current ElectricCharge input value for ECHeatedSmelter would be equivalent of 5661300EC/g or 5661300kJ/g or 5661.3TJ/t. That is far off from the 1584MJ/t that the comments in the config seem to be aiming towards.

1584MJ/t would work out to 1.584kJ/g resulting in a config value of 0.001584 ElectricalCharge. That seems a bit low in-game. If you also multiply that by the output mass of 3574.08g mentioned in the config comments, that would result in an ElectricalCharge input of 5.66134272. That still results in an extremely high in-game ElectricCharge usage, but in the thousands of units per second instead of millions.

It seems like my calculations might be missing something, but in any case, the current values are definitely not right. Personally, I settled on an ElectricCharge input of 0.1584 for my game. It results in an ElectricCharge usage of 141.66u/s with the electric smelters shown in the screenshot above (they use a rate of 5), which is about 5 times higher than the 30u/s that the stock ISRU uses.