tanjera / infirmary-integrated

Medical device simulator for training healthcare professionals.
http://www.infirmary-integrated.com/
Other
40 stars 5 forks source link

PA Waveform w/ Right Atrial Placement (CVP) Not Drawing/Scaling Correctly #205

Closed tanjera closed 4 months ago

tanjera commented 4 months ago

Different from #204 because the waveform is entirely mis-drawn

image

But can be fixed by adjusting PAS/PAD pressure variables... likely just drawing below visible area on the Strip and being scaled upwards (to higher pressure area of Strip) when pressure is increased.

Caused by Scale() function being invoked... is necessary because the PA strip is scalable (Fixed vs. Auto-Scale) whereas the CVP strip is not (default fixed).

tanjera commented 4 months ago

Determined due to https://github.com/tanjera/infirmary-integrated/blob/398336ba90c3de8df0010a07578c0313fbe65370/II%20Library/Classes/Waveform.Draw.cs#L152C7-L152C73 ... instead of dampening the amplitude, it is reversing around the Y-axis; since most of the waveform is in the positive Y space, it is dropping off the negative scale.

Since this is the only implementation of DampenAmplitude_DiastolicFillTime receiving a non-default coefficient, and it is obviously problematic, am going to remove the non-default option from the constructor.

tanjera commented 4 months ago

Fixed in da3493f