search

tanjiajiajun / pe

0 stars 0 forks source link

Different error messages #3

Open tanjiajiajun opened 2 months ago

tanjiajiajun commented 2 months ago

Screenshot 2024-04-19 at 4.29.06 PM.png

Screenshot 2024-04-19 at 4.28.55 PM.png

These 2 should be the same error message, and the second command is indeed a positive integer. May affect if number of users is large

nus-pe-script commented 2 months ago

Team's Response

This is the same "out of bound" index error but with the delete command instead of the addCategory command.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Misleading Error Message for addCategory

To reproduce: Run addCategory 2147483647 c/Clan d/rainbow

image.png

The command format is valid according to the prompts, but the error message says it is invalid, which may mislead users who might not know how to resolve it.

To Resolve: Change error messages to index out of bounds for this case

[original: nus-cs2103-AY2324S2/pe-interim#895] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This counts as deliberate sabotage as it is caused by extreme user behavior such as not accounting for integer overflows, especially since the app fails gracefully and shows an error message. As such, in accordance to the CS2103T website guidelines, this will not be considered a bug.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** How you partition your input for testing is clearly taught in CS2103, and in lecture it was said that common boundaries for testing values are INTEGER.MIN and INTERGER.MAX. This bug should have been already been detected in unit testing.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [x] I disagree **Reason for disagreement:** I found this bug to be a documentation issue as there was a mistake with the error message.