tanjiajiajun / pe

0 stars 0 forks source link

Phone number accepts alphabets #7

Open tanjiajiajun opened 2 months ago

tanjiajiajun commented 2 months ago

Screenshot 2024-04-19 at 4.55.55 PM.png

should be able to catch that phone number should follow a format. or at least just accepts numbers

nus-pe-script commented 2 months ago

Team's Response

This is a design choice, as we do not restrict the user in adding any characters in descriptions. If the user chooses to have a category of "Phone number" and a description of "I dont know his hp" this is a valid input due to the nature of this app being one for gamers, thus being given more freedom.

It was also specified in the ug that all characters will be allowed for a description.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This is why i picked it as a feature flaw. This feature could have been implemented more properly. In your example, you have things like email and phone number listed as categories, which means an intended use is as such. Therefore, this feature could have been better implemented if you have checker for more common categories, such as email, phone etc.


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** This is why i picked it as a feature flaw. This feature could have been implemented more properly. In your example, you have things like email and phone number listed as categories, which means an intended use is as such. Therefore, this feature could have been better implemented if you have checker for more common categories, such as email, phone etc.
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** The severity should be at least low, if not even medium. These common categories are used by everyday users, and typos are very common. It would be good for the app to notify the user when the phone number/email is clearly wrong.