tanjiaxian99 / pe

0 stars 0 forks source link

Incorrect error message for time that exceeds 60 minutes #11

Open tanjiaxian99 opened 2 years ago

tanjiaxian99 commented 2 years ago

Steps to reproduce:

  1. add 1 -tnSell Book -td2021-02-28 -tt00:90

Expected: Error message: Task time should not exceed 60 minutes

Actual: Error message: Task time should be of format HH:MM

image.png

nus-pe-bot commented 2 years ago

Team's Response

image.png

The image above is extracted from Wikipedia.

A HH:MM format is only considered valid when :

So it's fair to say that when MM is 90, it is not following the HH:MM format.

Furthermore, the command text is not cleared when it is invalid. And with the result message stating invalid HH:MM format, it will redirect users to see the HH:MM portion of the command text and let them realise that they did not use a valid MM value. Therefore no inconvenience is caused as a result.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]