search

tanjiaxian99 / pe

0 stars 0 forks source link

Incorrect error message for invalid task index #14

Open tanjiaxian99 opened 3 years ago

tanjiaxian99 commented 3 years ago

Steps to reproduce:

  1. edit 1 -ti0 -tnDrink Milk

Expected: Error message: Invalid task index

Actual: Error message: Invalid command format

image.png

nus-pe-bot commented 2 years ago

Team's Response

image.png

Our format stated that the parameter for -ti is a POSITIVE INTEGER. It is explicitly stated in the UG as well as the error message. Hence, using 0 for the parameter of -ti is considered as an invalid format as 0 is not a positive integer to begin with.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While we can argue on what it means to have an invalid command format, the fact still stands that the error message is not very intuitive. Saying incorrect command format does not exemplify to the user what is wrong with their command. Incorrect command format can mean a typo in the flag, a typo in the command word, an invalid index, etc. This causes minor convenience to users who are still new to the command's format. This issue is also exemplified in the module's website as shown below:

image.png

As such, this issue is more of a feature flaw than a functionality bug, but it remains as a bug of low severity.