Student able to have 2 Grades for the same Test

[tanjieling0]

A student can have multiple grades for the same test

input commands:

Step 1: edit 2 !g

Step 2:

Result: David now has 2 grades for the same midterms:

This could cause inconvenience to tutors, as they might lose data of the grades of the student, as they do not know which is the correct one. Given that this app is tailored to tutors, who often do not hold records of the students' school exam results, this can cause much hassle and embarrassment for tutors to have to text the students to retrieve their results again.

Perhaps this could be solved with a validity check for the grade input such that the test cannot have duplicates.

[soc-se-bot]

Team's Response

Thank you for the observation. However, we do not agree with the severity rating of high in #3470/medium here in #3552. Realistically, no student would have two exams of the same names, given that exam test names are unique by default. Therefore, in order for this bug to occur, the user must have intentionally entered the same test name multiple times. If the user had wished to instead update the test score, he could have done so using the edit functionality, instead of adding another with the same name. By the garbage-in-garbage-out principle, the user is thus at fault for inputting flawed information leading to the unexpected behaviour of the sort feature listed in #3470, and in viewing duplicate test scores here in #3552. As this bug does not make anything else go haywire or impact anything adversely, we believe that this bug is of a low severity.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

• [x] I disagree

Reason for disagreement: First, I would argue that test names are not unique by default.

It is very plausible for a student to have 2 exams with the same name. In the team's UG, most of the tests are named CA1, midterms etc. It is very plausible that a tutor teaches multiple subjects such as Elementary Mathematics (E. Math) and Additional Mathematics (A. Math) to the same student. Hence, there is a high chance that the tutor may key in midterm as the test name for both the E. Math and A. Math results, following the convention used by the team in their UG. Therefore, it is a realistic scenario and that a tutor does this, resulting in 2 different grades for the "same test".

Another scenario: Even if the tutor is cautious and perhaps does not follow the UG convention and names the exams AMath Midterms, the tutor could teach a student for multiple years, and there would be many midterms exam results through the years resulting in many AMath Midterms grades.

Therefore, the user is not at fault for inputting flawed information, as there are indeed 2 different midterms, each with a different score.

Since this situation causes catastrophic consequences as mentioned in the original bug report, I believe that this bug is arguably even of severity.High because of the inconvenience and loss of data that tutors would face.

Secondly, another reason this is severity.High is because the team flagged the other bug Incorrect Sorting with Duplicate Tests #4 of severity.High as a duplicate of this bug. Given that this bug led to the dysfunction of the sort command which is one of the core function of the app, which can lead to confusion for many users, I believe that the severity is high as it makes the app rather unusable.

The duplicate bug, which is a separate function of the app, but fails due to this bug (I have accepted it as a duplicate as fixing this would resolve the sort command bug):

---