tahaafzal5
commented
3 years ago I got a chance to look at it. It looks great, but can you also please add Auto Layout constraints when you get a chance? :)
Closed nashirj closed 3 years ago
tahaafzal5
commented
3 years ago I got a chance to look at it. It looks great, but can you also please add Auto Layout constraints when you get a chance? :)
nashirj
commented
3 years ago Thank you! I did I thought. Do they not show up on your end?
tahaafzal5
commented
3 years ago They don't :/
nashirj
commented
3 years ago You're right, I'm seeing the same thing. I can't figure out what I'm doing wrong though. Can you help me tomorrow?
tahaafzal5
commented
3 years ago Yes, we can possibly look at it tomorrow (Sunday) or Monday
On Nov 22, 2020, at 12:31 AM, Nashir Janmohamed notifications@github.com wrote:
You're right, I'm seeing the same thing. I can't figure out what I'm doing wrong though. Can you help me tomorrow?
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/tanjyy/ridesio/pull/58#issuecomment-731705780, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALPB4EE65FLZLW7ESFRAOJLSRCV4LANCNFSM4T6CWSBQ.
nashirj
commented
3 years ago Ok, thanks. Let me know if you have time Sunday, otherwise we can talk about it in our Monday tag up
nashirj
commented
3 years ago While working on navigation, I realized that there were a whole bunch of auto layout issues in the other screens as well haha. We should definitely discuss this together during our meeting
tahaafzal5
commented
3 years ago Definitely! I just tried a bunch of stuff with the auto layout on the arrow icon, but couldn't really understand what's happening. Maybe the easiest/quickest thing would be to remove the arrows. Thoughts?
nashirj
commented
3 years ago Yeah that sounds like a good approach to me! I can delete them tomorrow
closes #8