search

tanjyy / ridesio

Ridesharing iOS application for college students. Won 2nd place in the iOS category at CodePath Demo Day 2020.
https://tanjyy.github.io/ridesio
1 stars 1 forks source link

User can now log out #66

Closed tahaafzal5 closed 3 years ago

tahaafzal5 commented 3 years ago

Closes #50

nashirj commented 3 years ago

The logout functionality looks good to me, but you shouldn't duplicate commits; I notice you have commit c4775c3 in this PR as well as the other one that you requested I review.

tahaafzal5 commented 3 years ago

Ah. Are the duplicates because I branched from the sign up branch and not from the main?

nashirj commented 3 years ago

yeah! I think that will cause it. you can just remake the branch from main and make your changes again?

tahaafzal5 commented 3 years ago

Yes, I’ll do that and create a PR then.

On Nov 22, 2020, at 9:23 PM, Nashir Janmohamed notifications@github.com wrote:



yeah! I think that will cause it. you can just remake the branch from main and make your changes again?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/tanjyy/ridesio/pull/66#issuecomment-731907020, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALPB4EEXPDUGDCMI4D5GNPLSRHISZANCNFSM4T64LQDQ.

tahaafzal5 commented 3 years ago

Closing this and will create a new PR.