tanjyy / ridesio

Ridesharing iOS application for college students. Won 2nd place in the iOS category at CodePath Demo Day 2020.
https://tanjyy.github.io/ridesio
1 stars 1 forks source link

Create New Rides and Populate Ride Offering Feed #73

Closed yaosarayin closed 3 years ago

yaosarayin commented 3 years ago

Closes #43 Closes #44 Closes #48

tahaafzal5 commented 3 years ago
Screen Shot 2020-11-27 at 10 00 53 PM

I think the dates and times are switched. Below Sioux Falls, SD, it should be Nov 30, 10 AM and under Minneapolis, it should be Dec 18 7 AM. Also, can you make the New Ride Offering a Scroll View? If the keyboard pops up on the Simulator, some fields are inaccessible. And lastly, on the New Ride Offering, since we are asking for departure date & time and return trip's date & time, can you change the "Select Estimated Arrival Time" to Select Departure Time for the return trip or something like that?

nashirj commented 3 years ago

I'll work on this

nashirj commented 3 years ago

Fixed:

Bugs to be fixed

nashirj commented 3 years ago

Wait this is not ready to merge, need to fix a couple things

nashirj commented 3 years ago

not sure why there are conflicts above, but this is still not ready to merge, I need to finish a couple things tomorrow, sorry

tahaafzal5 commented 3 years ago

Looks great so far though! Again, thanks so much!

nashirj commented 3 years ago

My pleasure! I fixed the merge conflict btw

nashirj commented 3 years ago

Will let you know when I finish up the rest sometime tomorrow

tahaafzal5 commented 3 years ago

Looks good!