tanjyy / ridesio

Ridesharing iOS application for college students. Won 2nd place in the iOS category at CodePath Demo Day 2020.
https://tanjyy.github.io/ridesio
1 stars 1 forks source link

Finish implementing booking ride. #87

Closed nashirj closed 3 years ago

nashirj commented 3 years ago

Some nice to haves would be pop up messages that let users know when things go wrong, such as trying to book a ride that they posted, or booking a ride twice (which is already accounted for in the code, just need to create some popup dialog or something that lets the user know).

One thing I ran into was circular dependencies with parse (i.e. it's not possible to have a list of rides for each user and a list of users for each ride). The way I solved this was to give each ride a list of riders (which are User objects).

Close #44 close #45 close #75 close #76 close #86

nashirj commented 3 years ago

I need to make one change before this is merged, please wait on that

nashirj commented 3 years ago

Should be good now after you review it @tahaafzal5

tahaafzal5 commented 3 years ago

Looks good!

I noticed that if I (logged in as Taha) go to someone else's (John D's) account details page, under the ride offerings section, I also see the rides they have booked. Is that how it should be or should I just see the rides that John D is offering. This isn't something that is really needed to be fixed before demo day, but something to think about fs. I can merge in after you look at it and confirm.

I attached a screenshot just for reference if the above isn't clear.

Screen Shot 2020-12-06 at 1 52 07 AM
nashirj commented 3 years ago

I see what you’re saying. I guess it makes sense to only show the rides that person is offering. I’ll change that, thanks

tahaafzal5 commented 3 years ago

Perfect!