Closed nashirj closed 3 years ago
I need to make one change before this is merged, please wait on that
Should be good now after you review it @tahaafzal5
Looks good!
I noticed that if I (logged in as Taha) go to someone else's (John D's) account details page, under the ride offerings section, I also see the rides they have booked. Is that how it should be or should I just see the rides that John D is offering. This isn't something that is really needed to be fixed before demo day, but something to think about fs. I can merge in after you look at it and confirm.
I attached a screenshot just for reference if the above isn't clear.
I see what you’re saying. I guess it makes sense to only show the rides that person is offering. I’ll change that, thanks
Perfect!
Some nice to haves would be pop up messages that let users know when things go wrong, such as trying to book a ride that they posted, or booking a ride twice (which is already accounted for in the code, just need to create some popup dialog or something that lets the user know).
One thing I ran into was circular dependencies with parse (i.e. it's not possible to have a list of rides for each user and a list of users for each ride). The way I solved this was to give each ride a list of riders (which are User objects).
Close #44 close #45 close #75 close #76 close #86