search

tanjyy / ridesio

Ridesharing iOS application for college students. Won 2nd place in the iOS category at CodePath Demo Day 2020.
https://tanjyy.github.io/ridesio
1 stars 1 forks source link

Text starts from the top left* instead of center. #94

Closed tahaafzal5 closed 3 years ago

tahaafzal5 commented 3 years ago

closes #78

nashirj commented 3 years ago

This is a great start! That said, the text should wrap in the text field

tahaafzal5 commented 3 years ago

I thought it was, I’ll re-do it.

On Dec 7, 2020, at 11:27 AM, Nashir Janmohamed notifications@github.com wrote:



This is a great start! That said, the text should wrap in the text field

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/tanjyy/ridesio/pull/94#issuecomment-740063275, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALPB4EEZ5EXZ36A6GUQQAX3STUF7NANCNFSM4UPTL2IQ.

nashirj commented 3 years ago

Apparently, we need to use a UITextView instead. Can you make this change? https://stackoverflow.com/questions/29056830/swift-text-field-wrap-to-new-line

tahaafzal5 commented 3 years ago

Yeah I made that change, can you review and merge in if it looks good?

nashirj commented 3 years ago

You need to change it to a UITextView, not a UITextField

nashirj commented 3 years ago

The behavior is still the same on my end

tahaafzal5 commented 3 years ago

Ahh! I see why - fixing it now.

On Dec 7, 2020, at 12:47 PM, Nashir Janmohamed notifications@github.com<mailto:notifications@github.com> wrote:

The behavior is still the same on my end

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/tanjyy/ridesio/pull/94#issuecomment-740107396, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALPB4EAEKO6EVZPQUB5OBH3STUPMJANCNFSM4UPTL2IQ.

tahaafzal5 commented 3 years ago

@nashirj does it work now for you?

nashirj commented 3 years ago

No, does it for you?

tahaafzal5 commented 3 years ago

That is weird - it works for me. If not, we can go over it in our call tonight.

Screen Shot 2020-12-07 at 1 07 27 PM
nashirj commented 3 years ago

Sounds good. I got pretty busy with work just now, so I am not sure I can look at it until later anyway, sorry about that.

tahaafzal5 commented 3 years ago

Yes, no worries!

nashirj commented 3 years ago

Are you sure that you updated the textfield to a textview on the storyboard? I see that you updated it in the viewcontroller

tahaafzal5 commented 3 years ago

I did, but for some reason it did not commit. Can you check now?

nashirj commented 3 years ago

looks great now, thanks!