search

tank-dev / tank

A 2D C++ game engine taking inspiration from FlashPunk
Boost Software License 1.0
12 stars 3 forks source link

Member variable names unconformant #24

Closed DavidTruby closed 11 years ago

DavidTruby commented 11 years ago

I know it sounds like I'm being obsessive, but technically variable names beginning with anything other than letters are not allowed by the standard. The reason the variable names compile as is is that _s are explicity excepted from this rule... and reserved for use by the standards committee :-). So, can we replace all cases of _ϕ with ϕ_ (where ϕ is the name of a variable)?

qualiaa commented 11 years ago

1) Yes, it's a work in progress (I guess I can do it now) and 2) Look at you with your showoff Φs.

DavidTruby commented 11 years ago

I was using ϕ as in the symbol for a formula in logic. You're using Φ as in the greek letter. Yes, they're different unicode code points ;-)

DavidTruby commented 11 years ago

Marking as a bug, I feel very strongly about standards conformance ;-)

Anstow commented 11 years ago

I'll get on it I want to do something useful today.

Anstow commented 11 years ago

It breaks stranded pretty spectacularly but its done.

DavidTruby commented 11 years ago

Yeah... I broke stranded with the logger as well

DavidTruby commented 11 years ago

I've fixed that part of stranded's brokenness xD

Anstow commented 11 years ago

I'm going to let Jamie do it as I can't commit to the stranded repository.

DavidTruby commented 11 years ago

Neither :-P