search

tankh99 / pe

0 stars 0 forks source link

No deassignPerson function found in code #10

Open tankh99 opened 5 months ago

tankh99 commented 5 months ago

I could not find any deassignPerson method found in the Model interface. In fact, I could not find any such function inside the Model, AddressBook or Group class in GitHub. Is it a mistake or is the code not updated?

Screenshot 2024-04-19 at 5.22.11 PM.png

Screenshot of the DG section

Screenshot 2024-04-19 at 5.20.24 PM.png

nus-pe-script commented 5 months ago

Team's Response

Good catch! This is indeed an error in the DG.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unclear references in the DG for implementation of delete command

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

The DG states that the delete feature is implemented using the AddressBook#deassignPerson method, which I cannot find in the code base on Github.

image.png

Refer to the screenshot below, I cannot find it in this file: https://github.com/AY2324S2-CS2103T-W10-4/tp/blob/master/src/main/java/seedu/address/model/AddressBook.java

image.png

[original: nus-cs2103-AY2324S2/pe-interim#3616] [original labels: type.DocumentationBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]