tankh99 / pe

0 stars 0 forks source link

Assigning the same group to a user wipes all their attendance #8

Open tankh99 opened 7 months ago

tankh99 commented 7 months ago

How to reproduce

  1. Mark attendance for any student (Alex Yeoh) for any group (TUT04)
  2. edit 1 g/TUT04
  3. Notice that all attendance data is wiped

Expected behaviour Attendance data is kept, since there is actually no change in groups

nus-pe-bot commented 7 months ago

Team's Response

Thanks for pointing out! This is indeed a behavior that we did not expect.

However, we would also like to point out that it is unlikely for students to be reassigned to another group in a real world scenario. The possibility of assigning a student to the same group is even smaller than that.

Furthermore, reassigning to the same group would be a user mistake.

Therefore, we believe that the above is a minor flaw that is unlikely to affect normal operations of the product. It would only appears in very rare situations and causes a minor inconvenience only.

For the above reasons, we would like to propose that the severity should be Low instead of Medium.

Hope this clarifies your concern!

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: > However, we would also like to point out that it is unlikely for students to be reassigned to another group in a real world scenario.

I agree that this may rarely occur

Therefore, we believe that the above is a minor flaw that is unlikely to affect normal operations of the product. It would only appears in very rare situations and causes a minor inconvenience only.

However, I do not agree that this would cause a minor inconvenience to the user. Consider the following scenario:

It's week 12, and the user for some unknown reason, accidentally edits one of their student's group to the same group. TUT04 -> TUT04. Thus, all attendance data is wiped. If the user didn't have a back up of the attendance data, then how would they proceed to retrieve the lost data? (I haven't been a TA before so I genuinely am not sure, so correct me if I'm wrong).

Note that this data loss is also quite important as it means a student's grades.

I'm using the definition of s.Medium that it should be either

  1. happens to ~50% users and causes some inconvenience
  2. happens to few users but causes a major inconvenience

If this is to be lowered to s.Low, perhaps you can explain why this is not a major inconvenience but just a medium inconvenience