tanliyon / gym-xiangqi

This repo sets up the environment to play Xiang Qi (chinese chess) following the OpenAI Gym framework.

GNU Lesser General Public License v3.0

32 stars 6 forks source link

Dkim/pygame update #33

Closed dooki114 closed 3 years ago

dooki114 commented 3 years ago

Description

Hojoung's recent merge has been added
materials added to xiangqi_game.py a. find_target_piece(): locates the piece object by detecting the clicks within the radius of the target piece image b. kill_piece(): checks if the coordinate is occupied by the enemy piece, and if so, kills it c. click_to_real_coor(): takes the clicked coordinate and returns the real coordinate d. init_timer(): initialize timer e. update_timer(): decrements timer every second and blit the change f. game_over(): when timer is up, display "game over" on screen, waits for 3 seconds before quitting game
some minor changes in constants, board, and piece

dooki114 commented 3 years ago

Overall looks good. Could you add docstrings and a little bit of inline comments in xiangqi_game.py for on_event(), to_real_coor(), find_target_piece() methods? Also, in the future, it would be nice if the new changes from main branch was merged using git instead of manual copy-paste method

extra comments were added to the methods that you mentioned, and I will make sure to use git for that next time.