tanliyon / gym-xiangqi

This repo sets up the environment to play Xiang Qi (chinese chess) following the OpenAI Gym framework.

GNU Lesser General Public License v3.0

32 stars 6 forks source link

Implement environment close and seed methods #35

Closed hojoungjang closed 3 years ago

hojoungjang commented 3 years ago

Description

This PR adds the following 2 changes to Xiangqi environment:

implement close() method
implement seed() method

Type of change

[ ] Bug fix (non-breaking changes which fixes an issue)
[x] New feature (non-breaking changes which adds certain functionality)
[ ] Documentation update (updating documentations)
[ ] Breaking change (fix that breaks existing functionality)

How has this been tested?

These methods seem almost too straightforward and simple to test, but I added bare minimum testing. Please let me know if I can improve the testing.