tanliyon / gym-xiangqi

This repo sets up the environment to play Xiang Qi (chinese chess) following the OpenAI Gym framework.
GNU Lesser General Public License v3.0
32 stars 6 forks source link

Update Python dependencies in requirements.txt and build system #74

Closed hojoungjang closed 3 years ago

hojoungjang commented 3 years ago

Description

Changes were made to better track our dependencies and resolve our ReadTheDocs documentation build error. It is complaining about setuptools-scm not installed during the build process.

We can of course install this by listing setuptools-scm as our Python dependency but then I think we can instead remove it from our setup.py script.

I initially had the import setuptools_scm for experiment purposes related to dynamically specifying version name for PyPI publishing, but then I believe this feature works just fine regardless of that import statement. If this is not true, we can still fix the issue by including it in our requirements.txt.

Changes:

Type of change

How has this been tested?

Dependabot and ReadTheDocs documentation build