tanliyon / gym-xiangqi

This repo sets up the environment to play Xiang Qi (chinese chess) following the OpenAI Gym framework.
GNU Lesser General Public License v3.0
32 stars 6 forks source link

Change General points #81

Closed hojoungjang closed 3 years ago

hojoungjang commented 3 years ago

Description

This PR changes the points assigned to the General. Generals used to be float('inf') to denote end of the game. However, this point scheme does not work nicely with machine learning algorithms which usually involves tensors of float32 or float64 types. float('inf') is just unnecessarily huge to be properly represented. Thus, we chose to represent the points for General to something very big in relation to other pieces while being a finite number.

Type of change

How has this been tested?

GitHub Actions: CI