search

tanmaykm / Thrift.jl

Thrift for Julia
Other
27 stars 14 forks source link

Add TBufferedTransport #12

Open aerotuck opened 8 years ago

randyzwitch commented 6 years ago

@tanmaykm Do you know how much effort it would take to implement TBufferedTransport, or if there is a pure Julia way to implement this functionality as a work-around?

I'm trying to replicate pymapd, which is a Thrift package for MapD. I am able to contact my database via your Julia package, but this line seems to indicate I need to use TBufferedTransport also:

https://github.com/mapd/pymapd/blob/master/pymapd/connection.py#L147

tanmaykm commented 6 years ago

TFramedTransport already does buffering and TBufferedTransport should be very similar to it. May be just split TFramedTransport to take the buffering parts out to create TBufferedTransport.

randyzwitch commented 6 years ago

Thanks, I'll take a look