search

tanmaykm / Thrift.jl

Thrift for Julia
Other
27 stars 14 forks source link

Use dirname(@__FILE__) instead of Pkg.dir #17

Closed tkelman closed 8 years ago

tkelman commented 8 years ago

This allows installing the package elsewhere.

Add testing against 0.5 to Travis - this runs the most recent RC now, release once final tags are done.

tanmaykm commented 8 years ago

Thanks. Thrift compiler couldn't be installed by the travis script since #4 and therefore the code generation tests fail. I'll check if it is possible now, else exclude the failing tests from travis script.

tkelman commented 8 years ago

Travis lets you use 14.04 now, but I guess you have to install Thrift manually?

tanmaykm commented 8 years ago

Yes. That's build from sources, because we patch Julia support into it. A required library dependency wasn't there on 12.04. Works on 14.04.

tanmaykm commented 8 years ago

18 has now included these commits